Feat/utc backtesting #244
Draft
Feat/utc backtesting #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So what are you suggesting? You seem to touch a lot of files here without many changes? |
WuonParticle
force-pushed
the
feat/utc_backtesting
branch
from
d4606a0 to
14fef69
Compare
Author
|
fixed the line ending issues. I don't use dashboard so creating a button is not something I can justify the time to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft full request to point out the fact that back testing is currently not using UTC and so can result in confusing results. I believe that this needs to be a button instead of just forcing UTC on everyone.