Check encoding when parsing request content, to support emojis and non ASCII alphabets#24
Open
meuble wants to merge 1 commit intohuyha85:masterfrom
Open
Check encoding when parsing request content, to support emojis and non ASCII alphabets#24meuble wants to merge 1 commit intohuyha85:masterfrom
meuble wants to merge 1 commit intohuyha85:masterfrom
Conversation
…n ASCII alphabets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is (in my point of view) a better fix to @funwarioisii PR (#23), handling encoding at Net::HTTP level. We don't force the encoding, but let Net::HTTP find the best encoding from headers, content-type, meta charset tags or inferring it from the text.
This allow support of any kind of encoding, including UTF-8.