adding contract for compliency with v1.1 of the spec #123
Conversation
Amxx
requested review from
EugeneYYY,
Ram-srini,
TomBarnes,
danintel,
manju956 and
manojgop
as code owners
Signed-off-by: Hadrien Croubois <hc@iex.ec>
Amxx
force-pushed
the
contracts-proxy-model
branch
from
354bc16 to
4789f76
Compare
There was a problem hiding this comment.
Please do not close and reopen PRs, especially without addressing issues. Use the Same PR. Thank you.
This PR has no DCO line (see PR #72 for details) in 1 of the 2 commits. All commits should be merged into 1 commit with a DCO line for the automated DCO check to pass. For you:
Signed-off-by: Hadrien Croubois <hc@iex.ec>
Also, others have other issues that may still need to be addressed from #72.
| // WorkerID → Worker | ||
| mapping(bytes32 => Worker) private m_workers; | ||
|
|
||
| // workerType → organizationId → appTypeId → WorkerID[] |
There was a problem hiding this comment.
From #72:
s/appTypeId/appTypeIds/
(I see no appTypeId here, only appTypeIds)
There was a problem hiding this comment.
appTypeIds are arrays of appTypeId
to make worker searcheable by invididual appTypeId, we have to split the set of supported appTypeIds and enter as many entries in this multidimensional mapping.
workerRegister's code should show that clearly
danintel
left a comment
danintel
left a comment
There was a problem hiding this comment.
The commits need to be merged with a DCO line before CI can allow this PR to be merged.
Signed-off-by: Hadrien Croubois <hc@iex.ec>
Amxx
force-pushed
the
contracts-proxy-model
branch
from
38b5223 to
e216da6
Compare
* enable build HW mode without requiring SGX HW and remove large test artifacts Signed-off-by: Michael Steiner <michael.steiner@intel.com> * docker images allowing for build in SGX HW mode, also including sawtooth related parts docker-compose files allowing automatic setup with various configurations of source, sgx mode, proxy (see header of docker/sawtooth*yaml) bumped up sgx sdk to 2.4, sgxssl to 2.4.1 and openssl to 1.1.0.j (but resort to default OS openssl) Signed-off-by: Michael Steiner <michael.steiner@intel.com> * automated building and running of run-test from current locally committed branch via docker-compose (and test target in docker/Makefile) remove obsolete dirs Signed-off-by: Michael Steiner <michael.steiner@intel.com> * resolve conflict with PR#124 and move all code generation to apprioriate makefiles Signed-off-by: Michael Steiner <michael.steiner@intel.com>
3 participants
Replaces #72