This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Enabling Worker-pool for standalone build #646
+313
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikamurthy
requested review from
EugeneYYY,
Ram-srini,
SriharshaSubbakrishna,
TomBarnes,
danintel,
dcmiddle,
manju956,
manojgop,
pankajgoyal2 and
rranjan3
as code owners
| if [ $START_STOP_AVALON_SERVICES = 1 ] ; then | ||
| echo "Starting Avalon Listener $VERSION ..." | ||
| is_sync_mode | ||
| is_sync_mode_on=$? |
Contributor
There was a problem hiding this comment.
why to use is_sync_mode_on when there is is_sync_mode?
Contributor
danintel
approved these changes
Jul 28, 2020
Contributor
danintel
left a comment
danintel
left a comment
There was a problem hiding this comment.
Approved, after making spelling corrections.
scripts/tcs_startpool.sh
Outdated
| allPorts=("bind zmq_url remote_storage_url") | ||
| for i in $allPorts ; do | ||
| # Port number of listerner, zmq and kv storage is picked from listener toml file. | ||
| # grep command reads the line as string from toml file which contails url.eg: bind = "http://localhost:1947". |
Contributor
There was a problem hiding this comment.
s/contails url.eg/contains the url. E.g./
scripts/tcs_startpool.sh
Outdated
| for i in $allPorts ; do | ||
| # Port number of listerner, zmq and kv storage is picked from listener toml file. | ||
| # grep command reads the line as string from toml file which contails url.eg: bind = "http://localhost:1947". | ||
| # awk command seperates the string into 3, based on ":" such as "http,//localhost,1947". |
Contributor
There was a problem hiding this comment.
s/seperates/separates/
s/into 3,/into 3 parts,/
scripts/tcs_startpool.sh
Outdated
|
|
||
| allPorts=("bind zmq_url remote_storage_url") | ||
| for i in $allPorts ; do | ||
| # Port number of listerner, zmq and kv storage is picked from listener toml file. |
scripts/tcs_startpool.sh
Outdated
| mv $TCF_HOME/config/wpe_config.toml{.b,} | ||
| fi | ||
|
|
||
| # Changing library name in wpe_config.toml file to support mutiple Workerpool |
scripts/tcs_startpool.sh
Outdated
| KME_URL="http://localhost:"$PORT | ||
|
|
||
| # START_STOP_AVALON_SERVICES doesn't control enclave manager. It will be | ||
| # once enclave manager runs as seperate container. |
scripts/tcs_startpool.sh
Outdated
| WORKER="kme-worker-"$WORKER_ID | ||
| echo $WORKER | ||
| # START_STOP_AVALON_SERVICES doesn't control enclave manager. It will be | ||
| # once enclave manager runs as seperate container. |
scripts/tcs_startpool.sh
Outdated
| # Saving the original file with .b extension and rewriting the new library name | ||
| echo "Writing to config file" | ||
| cp $TCF_HOME/config/wpe_config.toml $TCF_HOME/config/wpe_config.toml.b | ||
| # Check line by line and replace enclave lib file name appended with interger COUNT |
karthikamurthy
force-pushed
the
workerpool
branch
2 times, most recently
from
51a9d8b to
23ada1b
Compare
Signed-off-by: Karthika Murthy <karthika.murthy@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karthika Murthy karthika.murthy@intel.com