This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Fix Ethereum connector asyncio loop #703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace nested run_until_complete() with create_task() in Ethereum connector. The evet loop once started cannot be started again from within a coroutine. Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
rranjan3
requested review from
EugeneYYY,
Ram-srini,
SriharshaSubbakrishna,
TomBarnes,
danintel,
dcmiddle,
karthikamurthy,
manju956,
manojgop and
pankajgoyal2
as code owners
Ram-srini
approved these changes
Nov 6, 2020
| try: | ||
| daemon = EventProcessor(self._config) | ||
| asyncio.get_event_loop().run_until_complete(daemon.start( | ||
| asyncio.get_event_loop().create_task(daemon.start( |
Contributor
There was a problem hiding this comment.
Do you think similar fix required for fabric as well?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace nested run_until_complete() with create_task() in Ethereum
connector. The evet loop once started cannot be started again from
within a coroutine.
Signed-off-by: Rajeev Ranjan rajeev2.ranjan@intel.com