Merged
Conversation
096304b to
ff893e6
Compare
Member
|
Why delay the notification though? |
Contributor
Author
It's not a delay per say, but ultimately acts as an action timeout. If you imagine implementing the frontend for a notification daemon, the user would currently only have 3s to activate the notification action. That's a little small imo, so why not make it configurable |
Member
|
Oh okay, that makes sense. Though the |
Contributor
Author
Sure, I changed it to |
Member
|
Great. This should also be reflected in the manpage, and the changelog updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a flag to configure notification timeout
Things done
For new programs
For changes