Skip to content

grimblast: add timeout flag#173

Merged
fufexan merged 4 commits intohyprwm:mainfrom
Azazel-Woodwind:add-timeout-flag
Sep 14, 2025
Merged

grimblast: add timeout flag#173
fufexan merged 4 commits intohyprwm:mainfrom
Azazel-Woodwind:add-timeout-flag

Conversation

@Azazel-Woodwind
Copy link
Contributor

@Azazel-Woodwind Azazel-Woodwind commented Sep 14, 2025

Description of changes

Add a flag to configure notification timeout

Things done

  • For new programs

    • Add the program to the README table, with yourself as the maintainer
    • Add a README for the program itself
    • Add Makefile (and Nix derivation optionally, otherwise @fufexan will do it)
    • If the program is a script, add it to the CI checks matrix
  • For changes

    • Add changes to the CHANGELOG
    • Reflect your changes in the man pages (if they exist)

@fufexan
Copy link
Member

fufexan commented Sep 14, 2025

Why delay the notification though?

@Azazel-Woodwind
Copy link
Contributor Author

Azazel-Woodwind commented Sep 14, 2025

Why delay the notification though?

It's not a delay per say, but ultimately acts as an action timeout. If you imagine implementing the frontend for a notification daemon, the user would currently only have 3s to activate the notification action. That's a little small imo, so why not make it configurable

@fufexan
Copy link
Member

fufexan commented Sep 14, 2025

Oh okay, that makes sense. Though the -t short option will conflict with the one for --filetype in the upcoming #169. Maybe a different letter can be used instead.

@Azazel-Woodwind
Copy link
Contributor Author

Maybe a different letter can be used instead.

Sure, I changed it to -e, --expire-time which is more in line with the actual flag name for notify-send

@fufexan
Copy link
Member

fufexan commented Sep 14, 2025

Great. This should also be reflected in the manpage, and the changelog updated.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fufexan fufexan merged commit 7551821 into hyprwm:main Sep 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants