This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Conversation
missing role parameter in the client.py example in README.md, this fixes an error where the current code cannot talk to agent.py server. Signed-off-by: Daniel Benner <dbenner@us.ibm.com>
Contributor
|
Hello, are you sure this is the culprit? Pydantic should apply acp/python/src/acp_sdk/models/models.py Line 169 in c0f4b8c Regardless, we should merge this to make the example more explicit 👍 |
pilartomas
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missing role parameter in the client.py example in README.md, this fixes an error where the current code cannot talk to agent.py server.