Postgres via psycopg2 and Pickle initial implementation #3
+216
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Quick look at it tells me the dB and table should probably be able to be specified in the init With defaults of course. But anything that might need to be controlled should be able to be controlled at construction time (and always, as much as possible, with defaults) |
Contributor
Author
|
Agree with you. Also I suppose need to comment at least base classes. Add exceptions handling. Probably some tests. Methods to close connection after block exiting (exit, del) |
Contributor
|
Hey @webcraft16 would you mind finishing these fixes you discussed with Thor, please? Low priority. It would be nice to have this raw SQL persister as an alternative to SQLAlchemy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.