-
Notifications
You must be signed in to change notification settings - Fork 0
feat: better accessibility #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ted state management
…als tables using useEffect
…mic page visibility
…al count for apps, datasets, and workerpools
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ockchainComputing/explorer-v2 into feature/add-assets-order
…and SchemaSearch components
… in Footer, Navbar, and AddressChip
…k Explorer link in SmartLinkGroup; add role to Tabs component
…and attributes to input and error messages
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements accessibility improvements across the application with the following key changes:
- Adds new "ACCESS" tabs to workerpool, dataset, and app detail pages showing access/orderbook information
- Implements ARIA labels, roles, and descriptions for better screen reader support
- Refactors loading and outdated state management to bubble up from child components
- Adds semantic HTML attributes (type="search", role="searchbox", aria-live regions)
- Updates the iexec package from 8.18.0 to 8.20.0
Reviewed changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/$chainSlug/_layout/workerpool/$workerpoolAddress.tsx | Added ACCESS tab with WorkerpoolAccessTable component and state management |
| src/routes/$chainSlug/_layout/dataset/$datasetAddress.tsx | Added ACCESS tab with DatasetAccessTable component and state management |
| src/routes/$chainSlug/_layout/app/$appAddress.tsx | Added ACCESS tab with AppAccessTable component and state management |
| src/routes/$chainSlug/_layout/address/$addressAddress.tsx | Added ACCESS tab showing all three access tables |
| src/modules/workerpools/workerpool/WorkerpoolDealsTable.tsx | Refactored to use props for loading/outdated state, fixed typo in error message |
| src/modules/workerpools/workerpool/WorkerpoolAccessTable.tsx | New component for displaying workerpool access orderbook |
| src/modules/datasets/dataset/DatasetDealsTable.tsx | Refactored to use props for loading/outdated state, fixed typo in error message |
| src/modules/datasets/dataset/DatasetAccessTable.tsx | New component for displaying dataset access orderbook |
| src/modules/apps/app/AppDealsTable.tsx | Refactored to use props for loading/outdated state, fixed typo in error message |
| src/modules/apps/app/AppAccessTable.tsx | New component for displaying app access orderbook |
| src/modules/search/SearcherBar.tsx | Added ARIA attributes for search input and error messages |
| src/modules/datasets/SchemaSearch.tsx | Added ARIA labels to filter buttons |
| src/modules/Tabs.tsx | Added role="radio" to tab buttons |
| src/components/navbar/NavBar.tsx | Added aria-label to links and buttons, changed logo alt text |
| src/components/Footer.tsx | Added aria-label to social media links |
| src/components/PaginatedNavigation.tsx | Improved pagination logic and stability |
| src/components/ModeToggle.tsx | Enhanced aria-label for theme toggle |
| src/components/CopyButton.tsx | Added aria-label and type attribute |
| package.json | Updated iexec from 8.18.0 to 8.20.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.