ECSqlReader can see uncommitted changes on primary connection.#7740
Draft
ECSqlReader can see uncommitted changes on primary connection.#7740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imodel-native: iTwin/imodel-native#1012
Editing application need to read changes as present on primary connection.
ECSqlReaderuses concurrent queries to read data which uses separate connection which does not see current changes on primary db.This can be solved with
usePrimaryConnoption but we lose the concurrency in doing so.An alternative method is to use
PRAGMA read_uncommitted=1which only works if shared cache is on. So, this PR enables read_uncommitted from concurrent query and enables shared cache by default.I sent out an email to sqlite dev asking them if enabling shared cache is clever idea and if there is alternative or they can implement something new for WAL mode.
This is obsolete method and may cause concurrent queries to block each other on shared page cache.