fix oneAtATimeAction so it doens't start a new request until the old one finishes#9012
Merged
fix oneAtATimeAction so it doens't start a new request until the old one finishes#9012
Conversation
Collaborator
Author
|
@hl662 Can you please take this over for me? I can't see the build logs and I don't know what is failing. |
hl662
approved these changes
Feb 23, 2026
Contributor
hl662
left a comment
hl662
left a comment
There was a problem hiding this comment.
thanks keith, it was a missing changelog file that prevented build from passing
aruniverse
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race in OneAtATimeAction where a replaced pending request could trigger execution of the next pending request before the active request completed.
Added new test that shows this behavior and verified that old implementation failed the new test