Code quality configuration for Codeac.io#6
Open
michal-simon wants to merge 2 commits intoiaasweek:masterfrom
Open
Code quality configuration for Codeac.io#6michal-simon wants to merge 2 commits intoiaasweek:masterfrom
michal-simon wants to merge 2 commits intoiaasweek:masterfrom
Conversation
Author
|
Hi, how are you doing? I just wanted to ask if you had a chance to look at this PR. Is there anything blocking the merge? Happy to fix it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I briefly looked up your repo and saw a good amount of work you have done over here. Good job, man! 🥇
You recently also tried Codeac.io and you probably haven't had a good experience just because of lack of correct configuration.
I added configuration for Ansible analysis so Codeac.io knows where your YAML files live. We can not run Ansible analysis on any random YAML files because it can be used for anything, not only Ansible. In the config file, you can, therefore, specify which YAML paths contain Ansible and which not. I hope this will be helpful for you and find Codeac more useful after this. Right after you merge it, you should see much better results than before.
Let me know if you need any more help. Btw, Codeac.io can analyze way more Infrastructure as Code if you want to have a look.
Michal Šimon
CEO @ Codeac.io
PS: Keep doing open-source, please! We all appreciate your work a lot! :)