Open
Conversation
|
@iain why this wasn't merged? |
|
@PlugIN73 because the build is broken and there are merge conflicts must be fixed before any consideration of merging can happen. |
|
Has this change been abandoned? |
Author
|
@jonnyshaw89 When I made this change the main branch had a failing build and I hadn't checked in on this PR since then. I'll get everything fixed up and resolve merge conflicts in the next couple of days. |
|
Reviewed 6 of 6 files at r1. Comments from the review on Reviewable.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change supports message attributes by pulling them out of the request headers and storing them in the message object.
The receive action will generate the XML for any attributes stored on the message body.