Claude/fix gantt responsive fonts 011 c uv lx qnsp7 f4 cq3qm cob4#69
Claude/fix gantt responsive fonts 011 c uv lx qnsp7 f4 cq3qm cob4#69
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
cockpit/src/components/shared/Button.tsx
Lines 124 to 128 in f864593
Preserve font sizing in Button size variants
The size configuration now stores className values (text-sm, text-base) instead of fontSize, but the render path still injects fontSize: config.fontSize into the inline style while never applying config.className. Consequently config.fontSize is undefined for all variants, so every button renders at the browser’s default font size and the sm/md variants no longer appear smaller. Reintroduce explicit font-size settings (via style or class name) when computing className to keep the size variants functional.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ib823
force-pushed
the
claude/fix-gantt-responsive-fonts-011CUvLxQnsp7F4Cq3qmCob4
branch
from
ddc659d to
f864593
Compare
- Replace all hard-coded font sizes with responsive Tailwind utilities - Use CSS clamp() for fluid typography that adapts to viewport - Maintain accessibility with proper line heights and contrast - Apply changes across Gantt tool, Dashboard, Org Chart, UI Library, and shared components - Ensure consistent typography scale following design system This implements professional responsive typography similar to Apple's approach, using mathematical scaling (1.5× type scale) and viewport-based fluid sizing.
ib823
force-pushed
the
claude/fix-gantt-responsive-fonts-011CUvLxQnsp7F4Cq3qmCob4
branch
from
f864593 to
27113a8
Compare
…aphy - Fix WorkflowProgress.tsx: move className props from inside style objects to proper JSX attributes - Update ResourcePanelAntD.tsx: replace hard-coded font sizes with responsive Tailwind classes - Ensures valid React/JSX syntax and consistent responsive typography
- Fix 16 files where className was incorrectly placed inside style objects - Ensures valid React/JSX syntax across dashboard, organization, estimator, and shared components - Resolves webpack build errors caused by invalid style object syntax
2 participants
No description provided.