Skip to content

[patch] Allow mas update to work when no local mongodb #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whitfiea merged 4 commits into from
Jul 3, 2025
Merged

[patch] Allow mas update to work when no local mongodb #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c4ff0e
[patch] Skip BYO mongodb update
rawa-resul Jul 2, 2025
e897aae
[patch] Use mongo-upd branch of python-devops
rawa-resul Jul 2, 2025
df444fb
Merge branch 'master' into mongo-upd
rawa-resul Jul 2, 2025
a2ff105
[patch] Remove mas_devops.tar.gz
rawa-resul Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/src/mas/cli/update/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ def detectMongoDb(self) -> None:
currentMongoVersionMajor = currentMongoVersion.split(".")[0]

if targetMongoVersionMajor > currentMongoVersionMajor:
self.setParam("mongodb_action", "install")
# Let users know that Mongo will be upgraded if existing MongoDb major.minor version
# is lower than the target major version
# We don't show this message for normal updates, e.g. 5.0.1 to 5.0.2
Expand All @@ -401,7 +402,7 @@ def detectMongoDb(self) -> None:
self.showMongoDependencyUpdateNotice(currentMongoVersion, targetMongoVersion)
self.fatalError(f"Existing MongoDB Community Edition installation at version {currentMongoVersion} cannot be downgraded to version {targetMongoVersion}")
else:
h.stop_and_persist(symbol=self.successIcon, text=f"MongoDb CE is aleady installed at version {targetMongoVersion}")
h.stop_and_persist(symbol=self.successIcon, text=f"MongoDb CE is already installed at version {targetMongoVersion}")
else:
# There's no MongoDb instance installed in the cluster, so nothing to do
h.stop_and_persist(symbol=self.successIcon, text="No MongoDb CE instances found")
Expand Down
3 changes: 2 additions & 1 deletion tekton/src/pipelines/update.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,15 @@ spec:
# -------------------------------------------------------------------------
- name: mongodb_action
type: string
default: "install"
default: "none"
description: Set to 'install' to update mongodb instances in specified mongodb namespace
- name: mongodb_namespace
type: string
default: "mongoce"
description: Namespace where mongodb instances will be updated
- name: mongodb_version
type: string
default: ""
description: Override the target version of MongoDb (use with extreme caution)

# TODO: The role should look this up itself
Expand Down