Skip to content

feat: make get_table_comment work on OS390 and AS400 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bimalkjha merged 1 commit into from
Oct 10, 2025
Merged

feat: make get_table_comment work on OS390 and AS400 #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ibm_db_sa/reflection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@ class AS400Reflector(BaseReflector):
Column("TABLE_SCHEMA", CoerceUnicode, key="tabschema"),
Column("TABLE_NAME", CoerceUnicode, key="tabname"),
Column("TABLE_TYPE", CoerceUnicode, key="tabtype"),
Column("LONG_COMMENT", CoerceUnicode, key="remarks"),
schema="QSYS2")

sys_table_constraints = Table("SYSCST", ischema,
Expand Down Expand Up @@ -616,7 +617,13 @@ def has_sequence(self, connection, sequence_name, schema=None):
return c.first() is not None

def get_table_comment(self, connection, table_name, schema=None, **kw):
raise NotImplementedError()
current_schema = self.denormalize_name(schema or self.default_schema_name)
table_name = self.denormalize_name(table_name)
systbl = self.sys_tables
query = sql.select(systbl.c.remarks).\
where(systbl.c.tabschema == current_schema).\
where(systbl.c.tabname == table_name)
return {'text': connection.execute(query).scalar()}

@reflection.cache
def get_sequence_names(self, connection, schema=None, **kw):
Expand Down Expand Up @@ -884,6 +891,7 @@ class OS390Reflector(BaseReflector):
Column("OWNERTYPE", CoerceUnicode, key="ownertype"),
Column("TYPE", CoerceUnicode, key="type"),
Column("STATUS", CoerceUnicode, key="status"),
Column("REMARKS", CoerceUnicode, key="remarks"),
schema="SYSIBM")

sys_indexes = Table("SYSINDEXES", ischema,
Expand Down Expand Up @@ -993,7 +1001,13 @@ def get_schema_names(self, connection, **kw):
return [self.normalize_name(r[0]) for r in connection.execute(query)]

def get_table_comment(self, connection, table_name, schema=None, **kw):
raise NotImplementedError()
current_schema = self.denormalize_name(schema or self.default_schema_name)
table_name = self.denormalize_name(table_name)
systbl = self.sys_tables
query = sql.select(systbl.c.remarks).\
where(systbl.c.tabschema == current_schema).\
where(systbl.c.tabname == table_name)
return {'text': connection.execute(query).scalar()}

@reflection.cache
def get_table_names(self, connection, schema=None, **kw):
Expand Down