Fix Super key detection and shortcut validation#143
Open
shuresm57 wants to merge 1 commit intoicedman:mainfrom
Open
Fix Super key detection and shortcut validation#143shuresm57 wants to merge 1 commit intoicedman:mainfrom
shuresm57 wants to merge 1 commit intoicedman:mainfrom
Conversation
- Fix Super key (MOD4_MASK) not being captured in shortcut widget
- Add validation to require modifier keys for all shortcuts
- Allows Super+key combinations to be recorded
- Remove space key restrictions when combined with modifiers
Fixes icedman#50
Author
|
@icedman Did you see this? |
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#141 Super+Space is the default keybinding for input source switching - but other Super + works now.