warn when attempting to run egg using an unsupported version of go#113
Open
alexflint wants to merge 1 commit intoicexin:mainfrom
Open
warn when attempting to run egg using an unsupported version of go#113alexflint wants to merge 1 commit intoicexin:mainfrom
alexflint wants to merge 1 commit intoicexin:mainfrom
Conversation
Contributor
|
Hi @alexflint! You are right in that Eggos is currently tied to Go 1.16. Support for Go 1.17 and above requires support for the custom asm calling convention introduced in Go 1.17 (see #100). Regarding the warning message. Would it enough to do this on the Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this wonderful package!
I wonder whether you are interested in this pull request that checks that the version of go being executed is 1.16. With the wrong version of go, it looks like this:
Perhaps the test in this PR is too severe. Does eggos support older version of go, such as 1.15?