Skip to content

h2_util: use ap_cstr_casecmpn for header name checks #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icing merged 1 commit into from
Nov 4, 2025
Merged

h2_util: use ap_cstr_casecmpn for header name checks #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mod_http2/h2_util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,7 @@ static int contains_name(const literal *lits, size_t llen, nghttp2_nv *nv)
for (i = 0; i < llen; ++i) {
lit = &lits[i];
if (lit->len == nv->namelen
&& !ap_cstr_casecmp(lit->name, (const char *)nv->name)) {
&& !ap_cstr_casecmpn(lit->name, (const char *)nv->name, nv->namelen)) {
return 1;
}
}
Expand Down Expand Up @@ -1705,7 +1705,7 @@ static apr_status_t req_add_header(apr_table_t *headers, apr_pool_t *pool,
return APR_SUCCESS;
}
else if (nv->namelen == sizeof("cookie")-1
&& !ap_cstr_casecmp("cookie", (const char *)nv->name)) {
&& !ap_cstr_casecmpn("cookie", (const char *)nv->name, nv->namelen)) {
existing = apr_table_get(headers, "cookie");
if (existing) {
/* Cookie header come separately in HTTP/2, but need
Expand All @@ -1723,7 +1723,7 @@ static apr_status_t req_add_header(apr_table_t *headers, apr_pool_t *pool,
}
}
else if (nv->namelen == sizeof("host")-1
&& !ap_cstr_casecmp("host", (const char *)nv->name)) {
&& !ap_cstr_casecmpn("host", (const char *)nv->name, nv->namelen)) {
if (apr_table_get(headers, "Host")) {
return APR_SUCCESS; /* ignore duplicate */
}
Expand Down