Per-team togglable friendlyfire #148
Conversation
choke-dev
changed the title
BlueZeeKing
left a comment
BlueZeeKing
left a comment
There was a problem hiding this comment.
GUI stuff looks good
|
|
||
| /** Whether friendly fire is enabled for this faction (null = use global config) */ | ||
| @Field("FriendlyFire") | ||
| private Boolean friendlyFire; |
There was a problem hiding this comment.
Instead of using a boxed boolean type, this should use an enum with either true, false, or use config. I don't think our serialization system can handle this correctly as is and it would be more readable.
There was a problem hiding this comment.
Instead of having a new command for the friendly fire option, it should be added to the existing modify command
|
|
||
| public static void register() { | ||
| ServerLifecycleEvents.SERVER_STARTED.register(FactionsManager::serverStarted); | ||
| ServerLifecycleEvents.SERVER_STOPPING.register(FactionsManager::serverStopping); |
There was a problem hiding this comment.
oh sorry, this was supposed to be for another pr
also includes: #148 (comment)
There was a problem hiding this comment.
so basically, whenever the server shuts down before the save interval is triggered, all data stored in memory is just gone which gives me an "Invalid player data" error when attempting to join my dev server
There was a problem hiding this comment.
The server saves itself as it stops, I’m not sure why this is needed
| } | ||
|
|
||
| private static void save(MinecraftServer server) { | ||
| public static void save(MinecraftServer server) { |
2 participants
Resolves #147
feature in action:
reencoded.mp4