This repository was archived by the owner on Sep 29, 2019. It is now read-only.
Fixed: some strings and arrays in the context can break the template rendering due to PHP callables#5
Open
CamaroSS wants to merge 1 commit intoidlesign:masterfrom
Open
Fixed: some strings and arrays in the context can break the template rendering due to PHP callables#5CamaroSS wants to merge 1 commit intoidlesign:masterfrom
CamaroSS wants to merge 1 commit intoidlesign:masterfrom
Conversation
rendering due to PHP callables
Owner
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP can recognize an array or a string as a callable, causing unwanted changes to the template rendering process.
Example:
Expected:
Hello, Max!Got:
Hello, !It happens because 'max' is a function name in PHP, and
is_callable('max')evaluates totrue.We have to be more strict here.