Open
Conversation
reabse following::
* 0fd32bb - (HEAD, idning/mget-improve, mget-improve) unchange (10 hours ago) <idning>
* 705acab - clean code (10 hours ago) <idning>
* 32e8559 - correct, but not clean. (18 hours ago) <idning>
* fde1f12 - mget-improve almost done. (2 days ago) <idning>
* b30fa4f - mget split to many mget and send to backend (3 days ago) <idning>
* 7cf5625 - add frag_owner counter (4 days ago) <idning>
* 8a4f5c0 - (origin/master, origin/HEAD, idning/master) Update README.md (12 days ago) <Manju Rajashekhar>
2. fix req_done(nfrag_done) for memcache
…ess code 2. nfrag_done work for memcache
MSETNX Return: - 1 if the all the keys were set. - 0 if no key was set (at least one key already existed).
update .travis.yam update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis update travis
idning
changed the title
idning
added a commit
that referenced
this pull request
May 25, 2014
today we got a core of twemproxy::
$ gdb -c core.14420 ./bin/nutcracker
(gdb) bt
#0 0x000000302af2e2ed in raise () from /lib64/tls/libc.so.6
#1 0x000000302af2fa3e in abort () from /lib64/tls/libc.so.6
twitter#2 0x0000000000419c82 in nc_assert (cond=0x444dc0 "!TAILQ_EMPTY(&send_msgq) && nsend != 0", file=0x444aa8 "nc_message.c", line=745, panic=1) at nc_util.c:308
twitter#3 0x000000000040d0d6 in msg_send_chain (ctx=0x553090, conn=0x55b380, msg=0x0) at nc_message.c:745
twitter#4 0x000000000040d568 in msg_send (ctx=0x553090, conn=0x55b380) at nc_message.c:820
twitter#5 0x00000000004059af in core_send (ctx=0x553090, conn=0x55b380) at nc_core.c:173
twitter#6 0x0000000000405ffe in core_core (arg=0x55b380, events=65280) at nc_core.c:301
twitter#7 0x0000000000429297 in event_wait (evb=0x5652e0, timeout=389) at nc_epoll.c:269
twitter#8 0x000000000040606f in core_loop (ctx=0x553090) at nc_core.c:316
twitter#9 0x000000000041b109 in nc_run (nci=0x7fbfffea80) at nc.c:530
twitter#10 0x000000000041b20d in main (argc=14, argv=0x7fbfffecc8) at nc.c:579
(gdb) f 3
twitter#3 0x000000000040d0d6 in msg_send_chain (ctx=0x553090, conn=0x55b380, msg=0x0) at nc_message.c:745
745 ASSERT(!TAILQ_EMPTY(&send_msgq) && nsend != 0);
(gdb) l
740 if (msg == NULL) {
741 break;
742 }
743 }
744
745 ASSERT(!TAILQ_EMPTY(&send_msgq) && nsend != 0);
746
747 conn->smsg = NULL;
748
749 n = conn_sendv(conn, &sendv, nsend);
it is caused by this ``ASSERT`` at nc_message.c:745,
``conn_send`` send no more than ``NC_IOV_MAX(128)`` pieces in ``msg_send_chain``,
if the first fragment of MULTI-DEL response is send on last batch. and this is the last msg in send queue, the next call of ``msg_send_chain`` will got ``nsend == 0``::
following case show such a case:
1. mget on ``126`` keys
2. a mutli-del cmd
::
def test_multi_delete_20140525():
conn = redis.Redis('127.0.0.5', 4100)
cnt = 126
keys = ['key-%s'%i for i in range(cnt)]
pipe = conn.pipeline(transaction=False)
pipe.mget(keys)
pipe.delete(*keys)
print pipe.execute()
see: https://github.com/idning/test-twemproxy/blob/master/test_redis/test_del.py#L56-L63
more detail: http://idning.github.io/twemproxy-core-20140523.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on travis-ci, it will automatic run https://github.com/idning/test-twemproxy. I have use it in
idning/twemproxyhere is some running history:
https://travis-ci.org/idning/twemproxy