Open
Conversation
- Added utils/bignumber.ts - Implemented formatAmountBN and formatTokenAmountBN - Updated AssetsScreen to use BigNumber - Added getFiatValueBN method to PricingService
…port - Disabled `import/no-named-as-default` to avoid false positives with BigNumber - Added `"baseUrl": "."` to tsconfig for proper alias resolution - Updated import style to `import BigNumber from 'bignumber.js'` for better readability
…nto feature/bignumber-integration
AndriianChestnykh
requested changes
Dec 18, 2025
src/utils/bignumber.ts
Outdated
| /** Add two BN values */ | ||
| export const add = (a: BNValue, b: BNValue): BigNumber => bn(a).plus(b); | ||
|
|
||
| /** Subtract b from a */ |
Collaborator
There was a problem hiding this comment.
Please remove such an obvious comments. The code is self explanatory
Comment on lines
+14
to
+18
| /** | ||
| * Factory function to create a BN instance safely | ||
| * - Accepts string, number, or BN instance | ||
| * - Avoids precision loss from floating point numbers | ||
| */ |
Collaborator
There was a problem hiding this comment.
The function is self-explaining. Please remove such comments
AndriianChestnykh
approved these changes
Dec 18, 2025
…integration # Conflicts: # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.