-
Notifications
You must be signed in to change notification settings - Fork 6
Create sync-forks.yml #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| - name: Set up Git identity | ||
| run: | | ||
| git config --global user.name "IEEEAutomationBot" | ||
| git config --global user.email "webmaster@ieee.utoronto.ca" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this user has the necessary permissions to submit PRs for the other repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this user has the necessary permissions to submit PRs for the other repos
I think this is probably covered by grabbing the GH_TOKEN from what I presume is this hackathon template repo (secrets config settings), @guaaaaa correct me if I'm wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is user should have all access (if i set everything correctly). The GH_TOKEN is for authorization purpose.
You can see more details here in the "GitOps" section https://docs.google.com/document/d/1LMUwCeKUJjQRd3DhIZ-CZVeheR7SCSmE/edit?usp=sharing&ouid=111047183552148011769&rtpof=true&sd=true
.github/workflows/sync-forks.yml
Outdated
| FORKS=( | ||
| "ieeeuoft/newhacks" | ||
| # Add other forked repos here, like: | ||
| # "ieeeuoft/hardware" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add MakeUofT as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- maybe add a comment for something like ieeeuoft/aws if AWS is still occuring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added aws and makeuoft as a comment for now since those repos do not exist yet. I will test everything with newhacks only first, then i'll work on those repos
| git push origin $BRANCH_NAME | ||
|
|
||
| gh pr create --repo $FORK \ | ||
| --title "🔄 Sync from hackathon-template" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all PRs created will have the same PR title? If there is multiple PRs with the same title it would be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, maybe we can integrate variable $REPO_NAME in the commit message and body to better differentiate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a note of this and will come back to this. For now, i'll first make sure the process can create a PR
Overview
Unit Tests Created
Steps to QA