Add support for rendering local markdown images in mdv-gui #16
+108
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Test Release SummaryAll binaries built and signed successfully! ✅ Version: Artifacts CreatedLinux GUI archivesWindows GUI archivesGUI Checksums (SHA256)Platform Coverage
What was tested
Note: This is a test release. No artifacts were published to GitHub Releases or Homebrew. |
This commit enables the GUI to properly render local image references in markdown files (e.g., ). Changes: - Modified ToHTML() to accept markdown file path parameter - Added processLocalImages() function to convert relative image paths to base64-encoded data URIs - Updated app.go to pass file path to ToHTML() - Updated all test cases to pass empty string for new parameter - Added example markdown file with test images The solution converts local images to data URIs, which are embedded directly in the HTML. This works seamlessly in the Wails webview without requiring file system access from the frontend. Supported image formats: PNG, JPEG, GIF, SVG, WebP, BMP, ICO 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
iiAtlas
force-pushed
the
claude/render-local-markdown-images-011CUMRSoZTicntqCQcXJE85
branch
from
dc103ea to
1fb605f
Compare
🧪 Test Release SummaryAll binaries built and signed successfully! ✅ Version: Artifacts CreatedLinux GUI archivesWindows GUI archivesGUI Checksums (SHA256)Platform Coverage
What was tested
Note: This is a test release. No artifacts were published to GitHub Releases or Homebrew. |
🧪 Test Release SummaryAll binaries built and signed successfully! ✅ Version: Artifacts CreatedLinux GUI archivesWindows GUI archivesGUI Checksums (SHA256)Platform Coverage
What was tested
Note: This is a test release. No artifacts were published to GitHub Releases or Homebrew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the GUI to properly render local image references in markdown files (e.g.,
).
Changes:
The solution converts local images to data URIs, which are embedded directly in the HTML. This works seamlessly in the Wails webview without requiring file system access from the frontend.
Supported image formats: PNG, JPEG, GIF, SVG, WebP, BMP, ICO
🤖 Generated with Claude Code