Updated content-tag to 4.1.0 (soft-breaking) #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
added
breaking
ijlee2
force-pushed
the
update-content-tag
branch
from
897c8bb to
381d5c1
Compare
ijlee2
force-pushed
the
update-content-tag
branch
from
381d5c1 to
cfcc57d
Compare
ijlee2
commented
Dec 29, 2025
| `</div>`, | ||
| `\`, {`, | ||
| ` template_fd9b2463e5f141cfb5666b64daa1f11a(\`<div class={{styles.container}}>`, | ||
| `Hello world!`, |
Owner
Author
There was a problem hiding this comment.
Wrong indentation (should be 2 instead of 0).
ijlee2
commented
Dec 29, 2025
| ` static{`, | ||
| ` template_fd9b2463e5f141cfb5666b64daa1f11a(\``, | ||
| `<UserName @user={{@user}} />`, | ||
| ` template_fd9b2463e5f141cfb5666b64daa1f11a(\` <UserName @user={{@user}} />`, |
ijlee2
commented
Dec 29, 2025
| ``, | ||
| `<div class={{styles.container}} data-test-field="timestamp">`, | ||
| ` {{this.timestamp}}`, | ||
| `{{this.timestamp}}`, |
Owner
Author
There was a problem hiding this comment.
Wrong indentation (ideally 2 instead of 0).
ijlee2
commented
Dec 29, 2025
| ` {{@label}}`, | ||
| ` template_fd9b2463e5f141cfb5666b64daa1f11a(\`<UiFormField @errorMessage={{this.errorMessage}} @isWide={{@isWide}}>`, | ||
| `<:label as |l|>`, | ||
| `<label data-test-label for={{l.inputId}}>`, |
Owner
Author
There was a problem hiding this comment.
Wrong indentation (should be 2 instead of 0).
ijlee2
commented
Dec 29, 2025
Comment on lines
+290
to
+296
| ` {{@label}}`, | ||
| ``, | ||
| ` {{#if @isRequired}}`, | ||
| ` <span aria-hidden="true">`, | ||
| ` *`, | ||
| ` </span>`, | ||
| ` {{/if}}`, | ||
| ` </label>`, | ||
| ` {{#if @isRequired}}`, | ||
| ` <span aria-hidden="true">`, | ||
| ` *`, | ||
| ` </span>`, | ||
| ` {{/if}}`, |
Owner
Author
There was a problem hiding this comment.
Idempotency hard to guarantee with content-tag@4.1.0 (it seems to continue to indent code to the left).
ijlee2
changed the title
This was referenced Dec 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
content-tag@4.1.0introduced soft-breaking changes to@codemod-utils/ast-template-tag'stoEcma()andupdateJavaScript(). The changes since4.0.0affect<template>tags in a class body more.It's expected that end-users of a codemod have
prettierto restore format.