Include invalid status code when raising handshake error #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahlee
force-pushed
the
include-status-in-exception
branch
from
8565e06 to
6acbae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desired outcome of this PR is to include the actual failed status code when the
InvalidStatusCodeerror is raised during the websocket handshake. We've encountered several instances where websocket connections fail during the handshake with:invalid_status_code. However, when server logs are unavailable, it can be difficult to determine what the actual problem is to resolve it.In this PR, I've updated the error class to include the invalid status code as a member variable so that we can inspect the status code when handling this exception in our application.
Please let me know if this is a change you are amenable to, and if you have any guidance or suggestions for how to improve the PR itself.
Thanks!