Remove standard console logging and use zerolog #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+12
to
+14
| failedToDecodeJSONMessage = LogEvent{1005, "Failed to parse JSON into %s.\n"} | ||
| failedToEncodeJSONMessage = LogEvent{1006, "Failed to encode %s into JSON format.\n"} | ||
| failedToExecuteGremlinQueryMessage = LogEvent{1007, "Failed to execute Gremlin query.\n"} |
rebecacalazans
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR expands the zerolog usage in the repository, as it was only being used in the app instance and the general console logging was being made by standard
fmt.Println()calls.Now we have extended the
errorinterface for some structs that represent typed errors, and createdInfo()functions for typed log messages.How can I test it?
go build ../dont-panic-api.exeExamples
TODO
As mentioned with @rebecacalazans, we should implement logging to Azure Portal too. I plan to do that later.