Skip to content

Conversation

@ldcdsl
Copy link

@ldcdsl ldcdsl commented Apr 2, 2021

Hi Michael,

Here are some changes we would like to have in the framework to suit our current use.

  • add useTransaction parameter for oracle execute query
  • add ociBindByName, commit, rollback and getError function to facilitate the use of transactions
  • also delete in "Property To Update" when an element is unset
  • add gitignore for PhpStorm (.idea directory)

If you think it's possible to integrate them, it would allow us to use the main branch directly and not a "custom" version for us.

I remain at your disposal if you have any questions or wish to change the improvements I have made.

thank you in advance
Loïc

Copy link
Owner

@imikado imikado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 points:

  • no print in a sgbd class, you take the risk to broker other project with your print line
  • can you use same identation, it difficult to me to see your real modifications
  • don't pull to master, we have 3 active branch, please pull to each you want (v4, v5, v6) :https://github.com/imikado/mkframeworkLib/branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants