Skip to content

Comments

[packaging] Remove sed for exec as it breaks links not opening if installed with appimage package managers & add %U#194

Merged
dumbmoron merged 3 commits intoimputnet:mainfrom
Twig6943:main
Feb 15, 2026
Merged

[packaging] Remove sed for exec as it breaks links not opening if installed with appimage package managers & add %U#194
dumbmoron merged 3 commits intoimputnet:mainfrom
Twig6943:main

Conversation

@Twig6943
Copy link
Contributor

For your pull request to not get closed without review, please confirm that:

  • An issue exists where the maintainers agreed that this should be implemented.
    If such issue did not exist before, I opened one.
  • I tested that my contribution works locally, and does not break anything,
    otherwise I have marked my PR as draft.
  • If my contribution is non-trivial, I did not use AI to write most of it.
  • I understand that I will be permanently banned from interacting with this
    organization if I lied by checking any of these checkboxes.
  • The pull request contents are only relevant to the Linux platform, and can in
    no way be applied to other platforms.

[short description of your PR goes here]
As of right now if a user install helium with a package manager like soar or am the Exec on the .desktop file will be changed with the path to the executable and this messes up %U, making links not open properly. This pr fixes that.

Left: .desktop from --appimage-extract
Right: .desktop from helium installed via packages.toml which has; helium = { github = "imputnet/helium-linux", asset_pattern = "*x86_64.AppImage", version = "*" }

image

@Twig6943 Twig6943 changed the title [packaging] Remove sed for exec as it breaks links not opening if installed with appimage package managers [packaging] Remove sed for exec as it breaks links not opening if installed with appimage package managers & add %U Feb 11, 2026
@dumbmoron
Copy link
Member

Can you link the bug report for the problem that this is solving?

@Twig6943
Copy link
Contributor Author

Can you link the bug report for the problem that this is solving?

#99 its closed I know but same issue happens when u use an appimage package manager as i said

@Samueru-sama
Copy link

Exec=AppRun to the desktop entry makes no sense, appimage itself doesn't do anyhting with it. All the appimage runtime does is execute the AppRun in the filesystem, you can in fact ship an appimage without a .desktop entry and it will work without issue, appimagetool doesn't allow it because it runs desktop-file-validate on it but that can be easily be bypassed.

Additionally tools like sharun or go-appimage parse the Exec= key in the desktop entry since they replace AppRun with their own generic implementation and need to know the name of the binary to launch.

@dumbmoron
Copy link
Member

other than that, lgtm

@Twig6943
Copy link
Contributor Author

Removed the %U

@dumbmoron dumbmoron merged commit 5d340a3 into imputnet:main Feb 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants