修复百度接口 #129
修复百度接口 #129
Conversation
Summary of ChangesHello @wuaishare, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 这个拉取请求旨在修复百度接口的数据抓取问题，通过更新用户代理、增强数据解析逻辑以及扩展类型定义，确保了各种百度数据（如热搜、小说、电影等）能够被稳定且正确地获取和处理。这些改动提升了数据源的可靠性，并为未来可能的数据结构变化提供了更好的兼容性。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
src/routes/baidu.ts
Outdated
| const sData = JSON.parse(matchResult[1]); | ||
| const cardContent = sData.data?.cards?.[0]?.content ?? sData.cards?.[0]?.content; | ||
| const jsonObject = Array.isArray(cardContent) | ||
| ? Array.isArray(cardContent[0]?.content) | ||
| ? cardContent[0].content | ||
| : cardContent | ||
| : []; |
There was a problem hiding this comment.
这段代码存在两个问题：
- 可靠性:
JSON.parse(matchResult[1])可能会因为matchResult[1]不是一个有效的 JSON 字符串而抛出异常，这将导致整个请求失败。建议增加try...catch来处理潜在的解析错误。 - 可读性: 用于确定
jsonObject值的嵌套三元运算符虽然紧凑，但可读性较差，不易于维护。
建议将此代码块重构为使用 try...catch 和更清晰的 if/else 结构，以提高代码的健壮性和可读性。
let jsonObject: any[] = [];
try {
const sData = JSON.parse(matchResult[1]);
const cardContent = sData.data?.cards?.[0]?.content ?? sData.cards?.[0]?.content;
if (Array.isArray(cardContent)) {
if (cardContent.length > 0 && Array.isArray(cardContent[0]?.content)) {
jsonObject = cardContent[0].content;
} else {
jsonObject = cardContent;
}
}
} catch (error) {
// 建议记录错误用于调试
// logger.error("Failed to parse Baidu data", error);
}
src/routes/baidu.ts
Outdated
| cover: v.img ?? v.imgInfo?.src ?? "", | ||
| author: v.show?.length ? v.show : "", | ||
| timestamp: 0, | ||
| hot: Number(v.hotScore ?? v.hotTag ?? 0), |
There was a problem hiding this comment.
使用 Number() 转换热度值时，如果 v.hotScore 或 v.hotTag 是一个非数字字符串（例如 “新”、“热”），Number() 会返回 NaN。这可能会导致下游数据处理出现问题。建议使用 parseInt(..., 10) || 0 的方式进行转换，这样更安全，可以将 “123万” 这样的字符串解析为 123，并且在解析失败时回退到 0。
hot: parseInt(v.hotScore ?? v.hotTag, 10) || 0,1 participant
已经测试过了，没啥问题，cover、desc、hot都成功抓取到了。
"realtime": "热搜",
"novel": "小说",
"movie": "电影",
"teleplay": "电视剧",
"car": "汽车",
"game": "游戏"
这几个也做了测试，也都抓取正常。