Add modal to edit player roles#250
Open
SibiAkkash wants to merge 2 commits intoindia-ultimate:mainfrom
Open
Conversation
SibiAkkash
force-pushed
the
edit-player-roles
branch
2 times, most recently
from
006d85f to
32539d3
Compare
Contributor
|
Any pros of using dialog over the flowbite modal we were using till now? But yeah just read and it does give good out of box capability to open and close nicely |
Contributor
Author
I was seeing some issues with flowbite modals, for example the score modals sometimes wouldn't open. And we won't have to do flowbite init a bunch of times, to get it working. |
Contributor
Author
Exactly |
SibiAkkash
force-pushed
the
edit-player-roles
branch
from
32539d3 to
e49aad7
Compare
SibiAkkash
force-pushed
the
edit-player-roles
branch
2 times, most recently
from
69e8eea to
722a07e
Compare
Before v3.4.0 we couldn't use max-w-[any pixel value] https://tailwindcss.com/docs/max-width
SibiAkkash
force-pushed
the
edit-player-roles
branch
from
722a07e to
f705569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit-player-roles-2024-01-03_20.23.57.mp4
@punchagan can you push the API changes ? I'll test against that
The
<dialog>tag is my new favorite html tag 😄Fixes #251