Skip to content

Conversation

@S203932
Copy link
Contributor

@S203932 S203932 commented Dec 18, 2025

I changed the name of the field within the front-end to from registerCertificate to certificate. Thus, being identically within the one defined in the back-end.

@S203932 S203932 self-assigned this Dec 18, 2025
@S203932 S203932 linked an issue Dec 18, 2025 that may be closed by this pull request
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@S203932
Copy link
Contributor Author

S203932 commented Jan 9, 2026

What's being fixed with this pull request:

  1. populating the registrations fields with the Idp information
  2. OIDC and SAML can now also use this feature (the X509 filter wasn't present when doing Idp registration and it didn't populate the necessary session attributes)
  3. Error's from the certificate expiration pop-up window are now being caught
  4. The certificate field can be omitted from the application-registration.yml (along with all the other fields)

One thing to take note off is that the certificate field is part of the registration fields and therefore inherits all the properties of RegistrationFieldProperties. This means that one can configure readOnly and fieldBehaviour for certificate, though there is no benefit from this. Also, it should be noted that one should not set readOnly = true for certificate since this means that it is the Idp to provide the information about whether the certificate should be linked or not. If one does set this value to true, then it would most likely result in the user not being able to register as the Idp is not providing this required information for the registration.

Please advise, if any changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with auto filling registration fields from IdP

2 participants