Skip to content

Add a mapper argument for substitute #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaohao95 wants to merge 1 commit into from
Closed

Add a mapper argument for substitute #17

gaohao95 wants to merge 1 commit into from

Conversation

@gaohao95
Copy link

@gaohao95 gaohao95 commented Mar 13, 2020 •
edited
Loading

This PR is used for supporting inducer/sumpy#4.

@gaohao95 gaohao95 mentioned this pull request Mar 13, 2020
Open
2 tasks
@inducer
Copy link
Owner

inducer commented Mar 13, 2020

Thanks for working on this! Generally, I don't like this change much. substitute is a one-liner as it is, and I'm not sure it's worth it to make it a more reconfigurable one-liner. Instead, just simply call the mapper yourself. What do you think?

@gaohao95
Copy link
Author

gaohao95 commented Mar 14, 2020

Thanks for working on this! Generally, I don't like this change much. substitute is a one-liner as it is, and I'm not sure it's worth it to make it a more reconfigurable one-liner. Instead, just simply call the mapper yourself. What do you think?

Sure! That will work as well.

@gaohao95 gaohao95 closed this Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaohao95 @inducer