Bump baseline with new errors #296
Conversation
|
Some of these errors seem buggy, e.g. for
|
alexfikl
force-pushed
the
bump-baseline
branch
from
973ff88 to
a8a3b3b
Compare
.github/workflows/ci.yml
Outdated
| . ./ci-support-v0 | ||
| build_py_project_in_conda_env | ||
| cipip install pytest pyfmmlib scipy scipy-stubs matplotlib optype | ||
| cipip install pytest pyfmmlib scipy scipy-stubs matplotlib 'optype<0.15' |
There was a problem hiding this comment.
It pulls in the latest numpy-typing-compat, which pulls in numpy 2.4.0rc1, which seems to be causing all the new pyright errors on the CI:
https://github.com/inducer/pytential/actions/runs/20202177807/job/57995305672
Besides that, there's nothing wrong with it, the "bug" seems to be in some typing changes in numpy, not in optype.
There was a problem hiding this comment.
I think I would rather
- complain to numpy about this regression
- sweep these into the baseline
- leave optype unbounded
There was a problem hiding this comment.
Sure. The main reason I didn't do that to start with is because I don't have numpy 2.4.0rc1 locally and didn't know how to update the baseline :(
There was a problem hiding this comment.
Hm, actually, since numpy 2.4.0 isn't released yet, it feels a bit weird to add this to the baseline already?
There was a problem hiding this comment.
Still no, for me:
$ pip install 'optype[numpy]'
Using Python 3.14.0 environment at: myvenv
Resolved 3 packages in 7ms
Installed 3 packages in 17ms
+ numpy==2.3.5
+ numpy-typing-compat==20251206.2.3
+ optype==0.15.0
(even with an empty uv cache)
There was a problem hiding this comment.
Curiously, that's a behavior difference between uv pip and "normal" pip. 🤦 Normal pip pulls in the RC.
There was a problem hiding this comment.
Hm, I'm getting
Successfully installed numpy-2.4.0rc1 numpy-typing-compat-20251206.2.4 optype-0.15.0
I'm also on Python 3.13.11, if that makes any difference (seems to match the CI, if nothing else). Not quite sure why you're not getting numpy-typing-compat-20251206.2.4 too since that seems to be the latest version on PyPI?
There was a problem hiding this comment.
Curiously, that's a behavior difference between
uv pipand "normal" pip. 🤦 Normal pip pulls in the RC.
🤦
alexfikl
force-pushed
the
bump-baseline
branch
from
a8a3b3b to
1568e2b
Compare
alexfikl
force-pushed
the
bump-baseline
branch
from
1568e2b to
28a6247
Compare
2 participants
No description provided.