Feat: use filepath for files with the same name for all data source types #11819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
Jonah879
changed the title
dosubot
bot
added
size:L
Contributor
|
@Jonah879 Hello, I’ve tested the Confluence connector. The new method works quite well when there are no attachments. However, when a page includes attachments, Ragflow is unable to retrieve all the files correctly, and the generated attachment filenames are also incorrect. Can you make some test and fix it? |
Contributor
Author
|
@Magicbook1108 Would you like to take a second look at it? The retrieval, naming and sync should work properly now. |
Contributor
|
@Jonah879 |
Contributor
Author
|
@Magicbook1108 Thanks for the feedback. The notion connector should be fixed as well. |
Contributor
|
@Jonah879 Well done, all passed. Thanks ! |
dosubot
bot
added
the
💞 feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When there are multiple files with the same name the file would just duplicate, making it hard to distinguish between the different files. Now if there are multiple files with the same name, they will be named after their folder path in the storage unit.
This was done for the webdav connector and with this PR also for Notion, Confluence and S3 Storage.
Type of change
Contribution by RAGcon GmbH, visit us here