Open
Conversation
dusterbloom
added
documentation
hu55a1n1
requested changes
Oct 21, 2024
Member
hu55a1n1
left a comment
hu55a1n1
left a comment
There was a problem hiding this comment.
Thanks @dusterbloom! Added some comments to fix stuff.
README.md
Outdated
| [](https://github.com/informalsystems/cycles-quartz/pulls) | ||
| [](https://github.com/informalsystems/cycles-quartz/stargazers) | ||
| [](https://github.com/informalsystems/cycles-quartz) | ||
| [](https://github.com/informalsystems/cycles-quartz) |
Member
There was a problem hiding this comment.
I think the msrv is incorrect.
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
yup ... changed
README.md
Outdated
Comment on lines
1
to
2
| [](https://github.com/informalsystems/cycles-quartz) | ||
| [](https://github.com/informalsystems/cycles-quartz) |
Member
There was a problem hiding this comment.
These should point to the actual workflow to show their status.
README.md
Outdated
| @@ -1,3 +1,14 @@ | |||
| [](https://github.com/informalsystems/cycles-quartz) | |||
| [](https://github.com/informalsystems/cycles-quartz) | |||
| [](https://github.com/informalsystems/cycles-quartz/docs) | |||
Member
There was a problem hiding this comment.
I think we can remove these -> cov, issues, PRs, stars.
And add e2e (workflow status) and rust: stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds badges to the README.md as shown below
Quartz