Skip to content

feat(enclave): optional backup#345

Merged
MSalopek merged 8 commits intomainfrom
hu55a1n1/no-backup
Oct 7, 2025
Merged

feat(enclave): optional backup#345
MSalopek merged 8 commits intomainfrom
hu55a1n1/no-backup

Conversation

@hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Oct 6, 2025

This PR does the following ->

  • Change the Host API to make the backup/restore optional.
  • Adds a --no-backup option to the quartz CLI (and example enclaves) that defaults to false.
  • Improve log coloring (log levels are now colored, but ANSI colors in log messages are still not fixed - this is due to an upstream issue, see Regression: New tracing-subscriber breaks ANSI color and styling support tokio-rs/tracing#3369 and other related issues on the tracing repo) - tried reverting to old versions of tracing but that creates other problems, so not fixing in this PR.
  • Default to info level logs - this prints things related to backups, enclave status etc. that were previously not printed.
  • Fixed --pccs-url so it can be set from the quartz CLI which wasn't the case previously.

@hu55a1n1 hu55a1n1 marked this pull request as ready for review October 7, 2025 11:05
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MSalopek MSalopek merged commit d75be62 into main Oct 7, 2025
7 checks passed
@MSalopek MSalopek deleted the hu55a1n1/no-backup branch October 7, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants