feat(blobber): Use new /blobs lighthouse endpoint to fetch blobs from CL#58
Merged
feat(blobber): Use new /blobs lighthouse endpoint to fetch blobs from CL#58
/blobs lighthouse endpoint to fetch blobs from CL#58Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
requested changes
Jan 6, 2026
prestwich
reviewed
Jan 9, 2026
prestwich
requested changes
Jan 13, 2026
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
i was not requesting an error type. I was requesting a clear explanation of the API and why it was designed that way. I think that "give me whatever subset of X,Y,Z you have" is a useful API. I also think that "give me exactly X,Y,Z, or nothing" is a useful function. What I'm looking for 0 panics, and for the rustdoc to tell me exactly how to achieve both of those things
Evalir
commented
Jan 13, 2026
prestwich
requested changes
Jan 13, 2026
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
DRY the two functions
document that we assume the CL returns correct blobs and not unrelated data
…om CL This massively simplifies CL blob fetching code. Instead of having to match blobs with versioned hashes with potential problems, we can just ask for exactly the blobs we want using the slot and versioned hashes. It reduces the entire CL fetching code to an API call. Closes ENG-1667
Evalir
force-pushed
the
evalir/new-cl-api
branch
from
1abc53a to
ab28dcd
Compare
prestwich
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This massively simplifies CL blob fetching code. Instead of having to match blobs with versioned hashes with potential problems, we can just ask for exactly the blobs we want using the slot and versioned hashes. It reduces the entire CL fetching code to an API call.
Closes ENG-1667