test: add bundle type JSON vector generation tests#186
Merged
Conversation
Add comprehensive integration tests verifying the three distinct fill-handling behaviors across different drivers: - Call Bundle (SignetBundleDriver): OUTPUT missing fills without validation, just reports detected orders and fills - Send Bundle (SignetEthBundleDriver): ERROR on missing fills, stopping execution unless tx is marked revertible - Block Driver (SignetDriver): DROP TXN on missing fills, rejecting the invalid transaction but continuing block processing Tests use a shared scenario with three fill states (full, partial, missing) to verify each driver behaves correctly. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove redundant closure in wallet creation and apply rustfmt. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address PR review feedback: - Remove unused `host_txs` parameter from `order_bundle()` function - Consolidate three identical `call_bundle` tests into one comprehensive test since call bundle performs no fill validation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address PR review feedback by verifying orderer balance changes: - accepts_with_valid_fills: assert balance decreased after order executed - drops_tx_on_partial_fills: assert balance unchanged when order dropped Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update fill_behavior tests to use tokio::time::Instant instead of std::time::Instant to match the updated SignetEthBundleDriver API. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add test functions that generate JSON test vectors for EthBundle and CallBundle types. These vectors are used by the TypeScript SDK to verify cross-implementation serialization compatibility. The tests are marked #[ignore] to avoid polluting normal test output while remaining available for vector regeneration when needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
Evalir
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_eth_bundle_vectorstest tocrates/bundle/src/send/bundle.rsgenerate_call_bundle_vectorstest tocrates/bundle/src/call/ty.rs#[ignore]to avoid polluting normal test outputTest plan
cargo clippy -p signet-bundle --all-featurespassescargo +nightly fmtapplied🤖 Generated with Claude Code