[MOSIP-44197] - Update org and group for npm and maven publish #145
Conversation
WalkthroughUpdates to package and build metadata: JavaScript package name, version, and author updated; Kotlin Gradle publishing coordinates and POM organization/version values updated to new organization and release-candidate version. Changes
Sequence Diagram(s)(omitted — changes are metadata/documentation updates without new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
kotlin/PixelPass/publish-artifact.gradle (2)
47-53: Inconsistent developer metadata in aar publication POM.While the organization has been updated to
io.inji(line 51), the developer name and email still reference "Mosip" (lines 49-50). This inconsistency may confuse package consumers about the project's maintainers.🔧 Suggested fix to align developer metadata
asNode().appendNode('developers').appendNode('developer').with { appendNode('id', 'Your developer ID') - appendNode('name', 'Mosip') - appendNode('email', 'mosip.emailnotifier@gmail.com') + appendNode('name', 'INJI') + appendNode('email', 'info@inji.io') appendNode('organization', 'io.inji') appendNode("organizationUrl", "https://github.com/inji/pixelpass") }Note: Update the email address to the appropriate INJI contact email.
134-140: Inconsistent developer metadata in jarRelease publication POM.While the organization has been updated to
io.inji(line 138), the developer name and email still reference "Mosip" (lines 136-137). This mirrors the same inconsistency in the aar publication.🔧 Suggested fix to align developer metadata
asNode().appendNode('developers').appendNode('developer').with { appendNode('id', 'Your developer ID') - appendNode('name', 'Mosip') - appendNode('email', 'mosip.emailnotifier@gmail.com') + appendNode('name', 'INJI') + appendNode('email', 'info@inji.io') appendNode('organization', 'io.inji') appendNode('organizationUrl', 'https://github.com/inji/pixelpass') }Note: Update the email address to the appropriate INJI contact email.
🤖 Fix all issues with AI agents
In @js/package.json:
- Around line 2-5: The package name was changed to @injistack/pixelpass but
other artifacts still reference @mosip/pixelpass; update js/package-lock.json to
replace all occurrences of "@mosip/pixelpass" with "@injistack/pixelpass",
update js/Readme.md installation lines and all example occurrences to the new
package name, and ensure any npm install / npm link instructions reflect
@injistack/pixelpass; publish a deprecation notice on npm for the old
@mosip/pixelpass package pointing users to @injistack/pixelpass, add a Migration
or RELEASE_NOTES document that explains the rename and any import changes, and
run a repository-wide search for "@mosip/pixelpass" to update or notify
downstream/internal consumers so references are verified and updated.
In @kotlin/PixelPass/publish-artifact.gradle:
- Around line 1-2: Update the Kotlin README examples that still reference the
old Maven coordinates: in kotlin/Readme.md replace occurrences of the Gradle
dependency string "io.mosip:pixelpass:0.5.0" with the new coordinate
"io.inji:pixelpass:0.8.0-RC1" (the Gradle example on line ~16), and update the
Maven snippet to use <groupId>io.inji</groupId> and <version>0.8.0-RC1</version>
(the Maven example on line ~22) so the documentation matches the new group and
version declared in publish-artifact.gradle.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
js/package.jsonkotlin/PixelPass/publish-artifact.gradle
🔇 Additional comments (1)
kotlin/PixelPass/publish-artifact.gradle (1)
24-24: Maven publication groupId updated correctly.The groupId change to
io.injiis consistent with the top-level group declaration.
Signed-off-by: Swati Goel <meet2swati@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
kotlin/PixelPass/publish-artifact.gradle (1)
47-53: Consider updating developer information to match new organization.While the
organizationfield has been correctly updated toio.inji, the developername(line 49) andThe same applies to the jarRelease publication (lines 134-140).
📝 Suggested updates
appendNode('id', 'Your developer ID') -appendNode('name', 'Mosip') -appendNode('email', 'mosip.emailnotifier@gmail.com') +appendNode('name', 'INJI') +appendNode('email', 'inji.support@example.com') appendNode('organization', 'io.inji')Note: Replace with the actual INJI support email address.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
js/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
js/Readme.mdjs/package.jsonkotlin/PixelPass/publish-artifact.gradlekotlin/Readme.md
🚧 Files skipped from review as they are similar to previous changes (1)
- js/package.json
🔇 Additional comments (7)
kotlin/Readme.md (1)
16-24: LGTM! Documentation correctly updated to reflect new Maven coordinates.The dependency examples have been properly updated to reflect the organization change from
io.mosiptoio.injiand version bump to0.8.0-RC1. This aligns with the changes inpublish-artifact.gradle.js/Readme.md (3)
27-29: LGTM! Package name correctly updated.The npm package references have been properly updated from
@mosip/pixelpassto@injistack/pixelpass, consistent with the organization change.
41-41: LGTM! Repository URL updated.The git clone command now correctly references the new
inji/pixelpassrepository location.
55-158: LGTM! Import statements consistently updated.All import examples throughout the documentation have been updated to reference
@injistack/pixelpass, ensuring users will use the correct package name.kotlin/PixelPass/publish-artifact.gradle (3)
1-2: LGTM! Publishing coordinates correctly updated.The group and version have been properly updated to
io.injiand0.8.0-RC1, reflecting the organization change and release candidate status. The previous review comment about updating the README has been addressed by the changes inkotlin/Readme.mdincluded in this PR.
24-24: LGTM! Maven groupId updated consistently.The Maven publication groupId correctly matches the new organization.
1-2: Old coordinates have been properly updated.The search confirms that old Maven group coordinates (
io.mosip:pixelpass) and npm package references (@mosip/pixelpass) have been removed from dependency declarations throughout the repository. The remainingio.mosipreferences are internal Java package names and Android namespaces (e.g.,package io.mosip.pixelpass,namespace = "io.mosip.pixelpass"), which are unrelated to the published Maven group ID or npm package name and do not need to be changed.
✅ Actions performedReview triggered.
|
2 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.