-
Notifications
You must be signed in to change notification settings - Fork 12
[MOSIP-44195] Update kotlin-artifacts-build.yml #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
WalkthroughThe workflow file is updated to introduce a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/kotlin-artifacts-build.yml:
- Around line 24-31: Remove the trailing whitespace from the options value
"io/mosip " under the group_path input so it reads "io/mosip"; update the
options list in the group_path block (the "options" key) to ensure there are no
trailing spaces on any entries and that YAML remains properly formatted.
- Line 36: The workflow reference on the uses line incorrectly uses the
branch/tag name "@Mmaster"; update that to "@master" so the action reference
matches the correct branch (change the string in the uses entry
"mosip/kattu/.github/workflows/maven-publish-android.yml@Mmaster" to use
"@master"). Ensure the other job references remain consistent (e.g., the
"publish-release" job already using "@master") and commit the corrected uses
value.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/kotlin-artifacts-build.yml
🔇 Additional comments (2)
.github/workflows/kotlin-artifacts-build.yml (2)
40-40: LGTM!The GROUP_PATH parameter is correctly passed from the workflow input. The
#dynamiccomment is optional and could be removed for cleaner configuration if desired.
54-58: LGTM!The workflow reference correctly points to
@masterand the GROUP_PATH parameter is properly forwarded from the input.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.