[backport] fix unfulfilled callbacks (#1297 and #1305)#1321
Open
vhakulinen wants to merge 3 commits intoinnoveit:v11.xfrom
Open
[backport] fix unfulfilled callbacks (#1297 and #1305)#1321vhakulinen wants to merge 3 commits intoinnoveit:v11.xfrom
vhakulinen wants to merge 3 commits intoinnoveit:v11.xfrom
Conversation
Backport innoveit#1297 for v11
vhakulinen
force-pushed
the
backport/fix-unfulfilled-callbacks
branch
from
3c7ce10 to
76a460b
Compare
vhakulinen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1297 and #1305 to v11.
Requires another commit from #1285 to apply the commit semi cleanly.
Haven't tested this yet, but throwing this here for others to see.Seems to work, but have to wait for user feedback (facing similar challenges with testing as reported in #1297)Update: I haven't been able to confirm that #1297 alone fixes the issues we're seeing, but I managed to notice a situation which #1305 fixes nicely.
Each commit includes information where the patch came from to make review easier.