Open
Conversation
Clarified the set up process for Windows users, since simply copy and pasting the echo command in Running Locally will result in invalid json on windows. I also added a sentence to the Building Binaries section stating that this step is unnecessary if you just want to run the game.
inolen
force-pushed
the
master
branch
29 times, most recently
from
dcd92ef to
98f91e4
Compare
inolen
force-pushed
the
master
branch
30 times, most recently
from
e588902 to
977b188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified the set up process for Windows users, since simply copy and pasting the echo command in Running Locally will result in invalid json on windows. I also added a sentence to the Building Binaries section stating that this step is unnecessary if you just want to run the game.
I struggled trying to set up emscripten thinking building the binaries was a necessary step, so I tried to make it clearer that the game could be ran as is simply by following the instructions in the next section. I did have to modify the creation of web.json, since I produced invalid json until I tried the command without the outer '.