Fixes download error in integration tests

[averissimo]

Pull Request

changes description

• Support older {testthat} API (pass was introduced in v3.3.0)
• Wait for output values to make sure table exists
  • if the wait is still not enough we'll add a app_driver$wait_for_idle(duration = 500) # extra wait for slow systems and tweak the duration

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      12  86.21%   116-121, 151-156
R/get_dt_rows.R                  13       0  100.00%
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255      79  69.02%   190, 315-389, 402-409, 411-416, 434, 436, 501, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52       4  92.31%   90-93
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      35  66.67%   113-114, 116, 124-155
R/white_small_well.R              7       0  100.00%
TOTAL                          1124     206  81.67%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: fffb1b1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   16 suites   2m 3s ⏱️
170 tests 170 ✅ 0 💤 0 ❌
392 runs  392 ✅ 0 💤 0 ❌

Results for commit fffb1b1.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
draggable_buckets	💔	$0.22$	$+8.29$	$+2$	$-3$	$0$	$0$
get_dt_rows_ui	💔	$0.04$	$+2.63$	$+4$	$-1$	$0$	$0$
optionalSelectInput_ui	💔	$0.11$	$+3.20$	$+14$	$-1$	$0$	$0$
optionalSliderInputValMinMax_ui	💔	$0.10$	$+2.21$	$+1$	$-2$	$0$	$0$
plot_with_settings_ui	💔	$0.21$	$+56.13$	$+32$	$-11$	$0$	$0$
table_with_settings_ui	💔	$0.15$	$+34.95$	$+51$	$-8$	$0$	$0$
verbatim_popup_ui	💔	$0.11$	$+7.30$	$+7$	$-3$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
draggable_buckets	💔	$0.07$	$+2.25$	e2e_teal.widgets_draggable_buckets_initializes_with_default_inputs
draggable_buckets	💔	$0.04$	$+3.25$	e2e_teal.widgets_draggable_buckets_initializes_without_input
draggable_buckets	💔	$0.04$	$+2.75$	e2e_teal.widgets_draggable_buckets_moving_elements_between_buckets_updates_input
get_dt_rows_ui	💔	$0.03$	$+2.58$	e2e_teal.widgets_get_dt_rows_rows_are_settable_and_visible
optionalSelectInput_ui	💔	$0.01$	$+3.13$	e2e_teal.widgets_optionalSelectInput_initializes
optionalSliderInputValMinMax_ui	💔	$0.01$	$+2.15$	e2e_teal.widgets_optionalSliderInputValMinMax_initializes
plot_with_settings_ui	💔	$0.04$	$+4.60$	e2e_teal.widgets_plot_with_settings_buttons_have_proper_FA_icons_and_two_of_them_are_dropdowns
plot_with_settings_ui	💔	$0.01$	$+4.25$	e2e_teal.widgets_plot_with_settings_clicking_download_download_button_downloads_image_in_a_specified_format
plot_with_settings_ui	💔	$0.02$	$+5.43$	e2e_teal.widgets_plot_with_settings_expanded_image_can_be_downloaded
plot_with_settings_ui	💔	$0.01$	$+9.00$	e2e_teal.widgets_plot_with_settings_expanded_image_can_be_resized
plot_with_settings_ui	💔	$0.00$	$+3.34$	e2e_teal.widgets_plot_with_settings_initializes_with_a_plot_and_the_settings_buttons
plot_with_settings_ui	💔	$0.01$	$+4.80$	e2e_teal.widgets_plot_with_settings_it_is_possible_to_set_height_and_width_for_the_plot_on_the_third_button_dropdown_menu_without_errors
plot_with_settings_ui	💔	$0.01$	$+4.74$	e2e_teal.widgets_plot_with_settings_main_image_can_be_resized
plot_with_settings_ui	💔	$0.01$	$+5.24$	e2e_teal.widgets_plot_with_settings_scrollbar_appears_when_image_is_resized
plot_with_settings_ui	💔	$0.01$	$+4.62$	e2e_teal.widgets_plot_with_settings_the_click_on_the_download_button_in_expand_modal_opens_a_download_dropdown
plot_with_settings_ui	💔	$0.01$	$+5.27$	e2e_teal.widgets_plot_with_settings_the_click_on_the_expand_button_opens_an_overlay_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
plot_with_settings_ui	💔	$0.01$	$+4.84$	e2e_teal.widgets_plot_with_settings_the_click_on_the_resize_button_opens_a_dropdown_menu_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
table_with_settings_ui	💔	$0.02$	$+4.48$	e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_first_button
table_with_settings_ui	💔	$0.01$	$+4.73$	e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_modal_on_the_second_button
table_with_settings_ui	💔	$0.02$	$+3.76$	e2e_teal.widgets_table_with_settings_clicking_download_download_button_downloads_table_in_a_specified_format
table_with_settings_ui	💔	$0.01$	$+4.97$	e2e_teal.widgets_table_with_settings_clicking_download_in_an_expand_modal_opens_dropdown_menu_with_dwnl_settings_such_as_file_type_file_name_pagination
table_with_settings_ui	💔	$0.02$	$+4.81$	e2e_teal.widgets_table_with_settings_expanded_table_can_be_downloaded
table_with_settings_ui	💔	$0.01$	$+3.21$	e2e_teal.widgets_table_with_settings_is_initialized_with_2_buttons_and_a_table
table_with_settings_ui	💔	$0.02$	$+4.55$	e2e_teal.widgets_table_with_settings_the_click_on_expand_button_opens_a_modal_with_a_table
table_with_settings_ui	💔	$0.02$	$+4.44$	e2e_teal.widgets_table_with_settings_the_click_on_the_download_button_opens_a_download_menu_with_file_type_file_name_and_download_button
verbatim_popup_ui	💔	$0.01$	$+3.41$	e2e_teal.widgets_verbatim_popup_is_initialized_with_a_button_that_opens_a_modal_with_a_verbatim_text
verbatim_popup_ui	💔	$0.05$	$+3.83$	e2e_verbatim_popup_button_can_be_disabled_and_enabled

Results for commit 6cadd65

♻️ This comment has been updated with latest results.

[llrs-roche]

Does it mean that tests use an old version of testthat?