Fixed an error was being raised as pointed at #12 even if one follow … #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2016 11:49
…llow the docs:
Warning: Failed propType: Required prop `form` was not specified in `BootstrapForm`. Check the render method of `App`.
As far as I see the `required` of form is only used in order to guarantee it is used between a newforms.Form tag. But if you don`t pass it, an error is raised anyway:
Uncaught TypeError: Cannot read property `__patchedByBootstrapForm` of undefined
So I removed the mandatory form and made a validation inside render.
…llow the docs:
Warning: Failed propType: Required prop `form` was not specified in `BootstrapForm`. Check the render method of `App`.
As far as I see the `required` of form is only used in order to guarantee it is used between a newforms.Form tag. But if you don`t pass it, an error is raised anyway:
Uncaught TypeError: Cannot read property `__patchedByBootstrapForm` of undefined
So I removed the the "required" form property on propTypes and made a validation inside render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an error was being raised as pointed at #12 even if one follow the docs the docs:
As far as I see the
requiredof form is only used in order to guarantee it is used between a newforms.Form tag. But if you don`t pass it, an error is raised anyway:So I removed the mandatory form and made a validation inside render.
Feel free to refuse this fix since I`m not sure whether making form required has an important need that I was unaware of.