CHEF-28703 - Remove faraday-middleware for Faraday 2.0 compactability#732
Open
balasubramanian-s wants to merge 2 commits intomainfrom
Open
CHEF-28703 - Remove faraday-middleware for Faraday 2.0 compactability#732balasubramanian-s wants to merge 2 commits intomainfrom
balasubramanian-s wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: balasubramanian-s <balasubramanian.s@progress.com>
👷 Deploy Preview for inspec-azure processing.
|
✅ Deploy Preview for inspec-azure canceled.
|
balasubramanian-s
changed the title
There was a problem hiding this comment.
Pull request overview
This pull request updates Faraday dependencies to ensure compatibility with Faraday 2.x by removing the deprecated faraday_middleware gem and adding faraday-retry for retry functionality support.
- Replaced
faraday_middlewaregem withfaraday-retryin the Gemfile - Updated require statement in Azure backend to use
faraday/retryinstead offaraday_middleware
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Gemfile | Replaced faraday_middleware with faraday-retry and added comments explaining Faraday 2.x compatibility changes |
| libraries/backend/azure_require.rb | Updated require statement from faraday_middleware to faraday/retry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates our Faraday dependencies to ensure compatibility with Faraday 2.x. The changes remove the now-unnecessary
faraday_middlewaregem and add thefaraday-retrygem, which is required for retry functionality in Faraday 2.x. Additionally, the required statements in the Azure backend are updated to reflect these dependency changes.Dependency updates for Faraday 2.x compatibility:
faraday_middlewaregem and added thefaraday-retrygem in theGemfileto support built-in JSON parsing and retry middleware in Faraday 2.x.libraries/backend/azure_require.rbto replacefaraday_middlewarewithfaraday/retry.CONTRIBUTING.MD) document before submitting.Check List
rake lintpasses