[MBL-19504][Student] Extend Conferences E2E test with expand/collapse functionality #3458
Conversation
Add some copyright to some test classes. refs: MBL-19504 affects: Student release note: -
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds license headers to test files and implements expand/collapse functionality testing for conference groups. The changes are well-structured and follow the existing test patterns.
Positive Aspects
- ✅ Proper Apache License 2.0 headers added to all modified files (correctly dated for their original creation)
- ✅ Comprehensive test coverage for the expand/collapse feature with clear assertion messages
- ✅ Good use of descriptive logging with STEP_TAG and ASSERTION_TAG
- ✅ New page object methods follow existing naming conventions
- ✅ Test verifies both collapsed and expanded states
Issues Found
- Hardcoded timeout value (ConferenceListPage.kt:51) - The
DoesNotExistAssertion(5)uses a magic number for timeout - Missing KDoc comments (ConferenceListPage.kt:50, 84) - New public methods
assertConferenceNotDisplayedandclickExpandCollapseGrouplack documentation
Code Quality
The code follows Kotlin conventions and Espresso testing patterns. The test logic is clear and maintainable. Minor improvements noted in inline comments would enhance code documentation and maintainability.
Test Coverage
The new test appropriately validates the expand/collapse functionality for conference groups, including verification that items appear and disappear as expected. The test flow is logical and thorough.
Security & Performance
No security concerns identified. The changes are test-only and don't affect production code performance.
| onView(allOf(withId(R.id.title), withText(conferenceTitle))).assertDisplayed() | ||
| } | ||
|
|
||
| fun assertConferenceNotDisplayed(conferenceTitle: String) { |
There was a problem hiding this comment.
The DoesNotExistAssertion(5) uses a hardcoded timeout of 5 seconds. Consider using a constant or configuration value for consistency with other timeout values in the codebase. This would make it easier to adjust timeout behavior across all tests if needed.
| fun assertConferenceDisplayed(conferenceTitle: String) { | ||
| onView(allOf(withId(R.id.title), withText(conferenceTitle))).assertDisplayed() | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing KDoc comment. Consider adding documentation to explain what this method does and when it should be used, especially since it's a public method in a page object that other tests might use.
| onView(withId(R.id.title) + withText(R.string.newConferences) + withAncestor(R.id.conferenceListPage)).assertDisplayed() | ||
| } | ||
|
|
||
| fun clickExpandCollapseGroup(groupName: String) { |
There was a problem hiding this comment.
Missing KDoc comment. Consider adding documentation to explain this method's purpose, especially since it's used for toggling both expand and collapse actions.
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Fri, 19 Dec 2025 00:09:35 GMT |
|
Student Install Page |
Test Plan
testConferencesE2E()test in ConferencesE2ETest.ktChanges
clickExpandCollapseGroup()method to ConferenceListPage to support clicking conference group headers by namerefs: MBL-19504
affects: Student
release note: none