[v12] View + ContextView #2282
Open
[v12] View + ContextView #2282
+371
−423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
balzss
commented
Dec 8, 2025
balzss
force-pushed
the
v12-view-token
branch
from
8be5f73 to
3ace66d
Compare
matyasf
force-pushed
the
v12-view-token
branch
2 times, most recently
from
e0dbb3f to
f923c03
Compare
balzss
force-pushed
the
v12-view-token
branch
from
f923c03 to
57972fe
Compare
matyasf
force-pushed
the
v12-view-token
branch
from
57972fe to
b4acada
Compare
balzss
force-pushed
the
v12-view-token
branch
4 times, most recently
from
794f0ae to
b9a0366
Compare
matyasf
requested changes
Dec 9, 2025
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
See my comments. Also the shadows, borders look different in ContextView, is this normal?
packages/ui-view/src/View/styles.ts
Outdated
| borderColor: borderColor | ||
| }) | ||
| } | ||
| borderStyle: 'solid', |
Collaborator
There was a problem hiding this comment.
I dont see this in the token changelog
Contributor
Author
There was a problem hiding this comment.
I'll double check with the design
Collaborator
|
Also please fix test and add the token changes to the upgrade guide |
HerrTopi
requested changes
Dec 12, 2025
packages/emotion/src/styleUtils/__tests__/calcSpacingFromShorthand.test.tsx
Show resolved
Hide resolved
balzss
force-pushed
the
v12-view-token
branch
from
b9a0366 to
86c1a70
Compare
HerrTopi
approved these changes
Dec 15, 2025
…token-based theme system - Remove theme.ts files from View and ContextView components - Switch from withStyleRework to withStyle decorator - Update components to use NewComponentTypes and SharedTokens - Enhance calcMarginFromShorthand to support hyphen-case tokens - Add elevationTokenToBoxShadow utility for box-shadow token conversion - Add processBorderRadiusValue and processBorderWidthValue helpers - Add withFocusOutline parameter to calcFocusOutlineStyles - Fix ContextView placement padding override with high-specificity selector
balzss
force-pushed
the
v12-view-token
branch
2 times, most recently
from
e013d39 to
823c2fc
Compare
balzss
force-pushed
the
v12-view-token
branch
from
aef6419 to
61b31d3
Compare
… borderStyle to use token instead
Contributor
Author
|
@adamlobler the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4865
Summary
Migrates View and ContextView components to token-based theme system:
withStyleReworktowithStyledecoratorcalcMarginFromShorthand→calcSpacingFromShorthandwith support for hyphen-case tokens (e.g., 'medium-small')elevationTokenToBoxShadow,processBorderRadiusValue,processBorderWidthValuewithFocusOutlineparameter tocalcFocusOutlineStylesTest Plan
pnpm run test:vitest ui-viewpnpm run dev→ http://localhost:9090