[v12] fix(emotion): calcMarginFromShorthand direct CSS value handling #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed console warnings when using direct CSS values (like 0, auto, 12px) in the margin prop of components. The calcMarginFromShorthand utility now properly recognizes valid CSS values before attempting theme token lookup, eliminating unnecessary warnings while maintaining full backward compatibility.
Changes
Added CSS value recognition logic to calcMarginFromShorthand before theme token lookup:
New helper functions:
isCSSValue(): Detects valid CSS margin values using pattern matching
normalizeCSSValue(): Normalizes values (e.g., 'none' → '0')
Execution order (unchanged, just added CSS check first):
Recognized CSS values:
Keywords: '0', 'auto', 'none' (converted to '0')
Units: '12px', '0.5rem', '2em', '100%', etc.
Test plan
Apply different margin values to the Avatar (e.g., margin="0 small"), then verify the console warnings.
Co-Authored-By: 🤖 Claude